Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to set component version when scale-out #2306

Merged
merged 2 commits into from
Nov 9, 2023
Merged

allow to set component version when scale-out #2306

merged 2 commits into from
Nov 9, 2023

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Nov 8, 2023

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef3382f) 50.29% compared to head (524b8ca) 55.44%.

❗ Current head 524b8ca differs from pull request most recent head ea96e1c. Consider uploading reports for the commit ea96e1c to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2306      +/-   ##
==========================================
+ Coverage   50.29%   55.44%   +5.15%     
==========================================
  Files         324      325       +1     
  Lines       34693    34721      +28     
==========================================
+ Hits        17446    19248    +1802     
+ Misses      14962    13175    -1787     
- Partials     2285     2298      +13
Flag Coverage Δ
cluster 44.77% <100.00%> (-0.05%) ⬇️
dm 25.49% <0.00%> (+0.02%) ⬆️
playground 15.24% <0.00%> (-0.01%) ⬇️
tiup 15.54% <0.00%> (-0.01%) ⬇️
unittest 22.38% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/cluster/spec/spec.go 84.33% <100.00%> (+8.93%) ⬆️

... and 58 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 8, 2023
@kaaaaaaang
Copy link
Collaborator

/lgtm

@kaaaaaaang
Copy link
Collaborator

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Nov 9, 2023
@ti-chi-bot ti-chi-bot bot removed the lgtm label Nov 9, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 9, 2023

@nexustar: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 9, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 9, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-08 14:32:43.586336491 +0000 UTC m=+3654761.173446620: ☑️ agreed by srstack.
  • 2023-11-09 08:54:47.488849337 +0000 UTC m=+3720885.075959654: ✖️🔁 reset by ti-chi-bot[bot].
  • 2023-11-09 09:10:38.690086558 +0000 UTC m=+3721836.277196703: ☑️ agreed by kaaaaaaang.

@kaaaaaaang
Copy link
Collaborator

/approve

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 1224f7d into pingcap:master Nov 9, 2023
18 checks passed
@kaaaaaaang kaaaaaaang added this to the v1.14.0 milestone Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srstack srstack srstack approved these changes

Assignees
No one assigned
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nexustar @codecov-commenter @kaaaaaaang @srstack